feat: add mock SDK server for local dev and CI - #516
Merged
Conversation
Adds frontend/lib/sdk/mocks/ — an msw/node mock of bridgelet-sdk's account/claim endpoints (create account, check status, verify, redeem), covering exactly what scripts/check-sdk-contract.mjs declares as the frontend's real contract with the SDK. Started automatically via frontend/instrumentation.ts on every Next.js server boot, so local dev and CI no longer need a live bridgelet-sdk / testnet instance by default. Steps aside automatically when E2E_USE_MOCKS=false (already set by .github/workflows/compatibility.yml's real-SDK integration job), so no changes were needed to that workflow. The mock also serves its own GET /api/docs-json, so check-sdk-contract.mjs can be pointed at the mock itself to verify it hasn't drifted from the declared contract — documented step-by-step in frontend/lib/sdk/mocks/README.md, including the known AccountStatus enum gap this mock intentionally mirrors rather than silently fixes.
|
@bright5455 is attempting to deploy a commit to the aminubabafatima8-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@bright5455 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #463
Started automatically via frontend/instrumentation.ts on every Next.js server boot, so local dev and CI no longer need a live bridgelet-sdk / testnet instance by default. Steps aside automatically when E2E_USE_MOCKS=false (already set by .github/workflows/compatibility.yml's real-SDK integration job), so no changes were needed to that workflow.
The mock also serves its own GET /api/docs-json, so check-sdk-contract.mjs can be pointed at the mock itself to verify it hasn't drifted from the declared contract — documented step-by-step in frontend/lib/sdk/mocks/README.md, including the known AccountStatus enum gap this mock intentionally mirrors rather than silently fixes.
Executive Summary
Linked Issues & References
Type of Change
Category
Domain
Technical Implementation Details
Breaking Changes
Verification & Testing Strategy
Automated Tests
Manual Verification
1. Environment:
2. Reproduction Steps:
3. Proof of Execution:
Quality Assurance Checklist
By submitting this Pull Request, I acknowledge that I have adhered to the Bridgelet contribution guidelines.