fix(completion): offer --json flag for ls, agent ls, and secret ls - #226
Open
Voyagerroc-Lab wants to merge 1 commit into
Open
Voyagerroc-Lab wants to merge 1 commit into
Voyagerroc-Lab wants to merge 1 commit into
Conversation
…loses brig-sh#176) Signed-off-by: Voyagerroc-Code <325343927+Voyagerroc-Code@users.noreply.github.com>
Member
|
Thanks @Voyagerroc-Lab for contributing and taking on this. Can I ask you to adjust your commit header to be 72 characters with the Fixes as a git trailer at the end, then I am happy to approve this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #176.
Problem
--jsonis supported bybrig ls,brig agent ls, andbrig secret ls, but shell completion did not offer--jsonfor any of these three commands.Solution
--jsonto the allowed flag list forbrig lsincmd/brig/completion.go.flags: []string{"--json"}to theagent lsandsecret lssubcommand definitions withingroups.cmd/brig/completion_test.goverifying that completion offers--jsonforbrig ls -,brig agent ls -, andbrig secret ls -.Closes #176.