Conversation
`repository.branch` under homebrew_casks is the branch goreleaser pushes
the cask to, and the head of the pull request it opens. Set to main, the
first stable tag pushes straight to the tap's main and then has nothing to
open a PR from. brig's v0.2.0 run did exactly that on 2026-09-15, and the
tap's DCO ruleset refused the push with a 409. hull has the same line and
would fail the same way on its first stable tag.
The branch is now hull-{{ .Version }}, with main as the PR base, which is
what the comment beside it already described.
Signed-off-by: Anastassios Nanos <ananos@nofire.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first stable brig tag, v0.2.0, showed that
repository.branch: mainunderhomebrew_casksdoes not mean what the comment beside it says. It is the branch goreleaser pushes the cask to, and the head of the pull request it opens. Set to main, goreleaser pushes straight to the tap's main and then has nothing to open a PR from. On brig the tap's DCO ruleset refused that push with a 409 and the release run failed. hull carries the same line, so its first stable tag would fail the same way.The branch is now
hull-{{ .Version }}, with main as the PR base. brig shipped the same change in brig-sh/brig@131e3bc, and its second v0.2.0 run opened brig-sh/homebrew-brig#11 frombrig-0.2.0as intended.Related issues
Refs brig-sh/homebrew-brig#11.
Changes
.goreleaser.yaml:homebrew_casks.repository.branchishull-{{ .Version }}andpull_request.base.branchismain.goreleaser checkpasses.Checklist
make testpassesmake macosbuilds hull, vz-runner and hvi, if Go, Swift or Rust code changedI have added or updated tests covering the changeVerified by the equivalent change on brig's v0.2.0 release run.I have run the e2e harnesses (test/*.py) for changes touching boot, console, or the run pathdocs/):docs/releasing.mdalready describes the PR path, no change needed.