Simplify __init__.py#352
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EWB Pull Request
Description
__init__.pyfor EWB's src tree worked well prior but was both complicated and caused slow imports. This PR cleans up the file and swaps to a hierarchical import style.Type of change
If this PR is a breaking change, please explain:
What functionality is now broken?
Importing is changed slightly to improve import time, submodule calls (e.g.
.forecasts.ZarrForecast,.targets.ERA5) no longer work.What is the new approach?
The approaches are changed to explicitly import modules (e.g.
.inputs.ZarrForecast) instead. This avoids ambiguity in how to call a method or variable.Did you fix the documentation and up + downstream code accordingly?
Yes.
How Has This Been Tested?
All tests have been run to ensure everything imports successfully.
test_inithas been modified to handle the simplified version of the file.