Conversation
brimworks
approved these changes
Dec 30, 2025
Owner
brimworks
left a comment
There was a problem hiding this comment.
Glad it was such an easy upgrade. Thanks for the contribution!
Contributor
Author
|
@brimworks Do you want me to update the github workflow? I can do that in a few minutes. EDIT: LuaRocks 3.13.0 was released (and the GitHub actions). So I can update your testing workflow. |
Owner
|
If you're willing to, that would be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Lua 5.5 support
Notes
At the moment, there's NOT a released LuaRocks version that officially supports Lua 5.5. However, Lua 5.5 support on LuaRocks is progressing (see luarocks/luarocks#1844) and it is already able to build local modules.
Moreover, the current CI on this project is unable to properly test
lua-zlibon Lua 5.5, because the involved actions depends on official released LuaRocks versions.For this reason, I implemented the whole CI to test this PR branch on Ubuntu + macOS + Windows (both MSVC + MinGW-w64 on Windows) using https://github.com/luarocks/hererocks to install Lua 5.5 + LuaRocks from the commit
6b7b6c2506f9abef059794663a8598a736837cc4.You can browse how CI ran on my PR branch, including Lua 5.1 - 5.5, here: https://github.com/luau-project/ci-tests/actions/runs/20524106344
Click to hide/unhide the workflow employed in the tests