[CTM-133] Reverse call-caching order and delete old entries #7834
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aednichols
reviewed
Dec 9, 2025
|
|
||
| def allowResultReuse = column[Boolean]("ALLOW_RESULT_REUSE", O.Default(true)) | ||
|
|
||
| def createdAt = column[Timestamp]("CREATED_AT", O.Default(new Timestamp(System.currentTimeMillis()))) |
Collaborator
There was a problem hiding this comment.
I'm not sure this default will be used in a meaningful way, as it will be the DBMS calculating the current time rather than the JVM. In that sense, it is a bit confusing.
| CREATE EVENT IF NOT EXISTS delete_old_call_cache_entries | ||
| ON SCHEDULE EVERY 1 DAY | ||
| DO | ||
| DELETE FROM CALL_CACHING_ENTRY WHERE CREATED_AT < (NOW() - INTERVAL 90 DAY); |
Collaborator
There was a problem hiding this comment.
I think we probably want this configurable for non-Terra Cromwells... I'd be fine with shipping the sort reversal first and the cleanup later once we find a good way to do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes