CTM-285: Split tagging flags between job and hardware #7835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LizBaldo
commented
Dec 9, 2025
| "_" | ||
| ) | ||
| val doTagging = tagResources.getOrElse(false) | ||
| val doTagging = tagHardware.getOrElse(false) |
Contributor
Author
There was a problem hiding this comment.
This is the real change. doTagging triggers the _add_tags functions on the EBS volumes and EC2 instances
Contributor
There was a problem hiding this comment.
so just to clarify, the jobs will still be tagged even if doTagging isn't true?
Contributor
Author
There was a problem hiding this comment.
Yes, doTagging is used just to enable the function that tags the EC2 instance and the EBS volumes, if you search for propagateTag in this file, you will see that it will still depend on tagResources
added 2 commits
December 9, 2025 16:51
lucymcnatt
approved these changes
Dec 10, 2025
walarue
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JIRA Ticket: https://broadworkbench.atlassian.net/browse/CTM-285
Some users (Manifold) might not want to tag the actual hardware, only the AWB batch job. This change should allow for that.
I just looked at the integration test, and things looks good, with only tagResources we get
Before we were getting:
Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes