Show filament_id as read-only field in filament preset editor#2
Open
broncosis wants to merge 3 commits into
Open
Show filament_id as read-only field in filament preset editor#2broncosis wants to merge 3 commits into
broncosis wants to merge 3 commits into
Conversation
added 2 commits
June 25, 2026 19:02
…data When OrcaSlicer reads lane_data from Moonraker, it now checks filament_id and setting_id fields first (populated by spoolman-lane-sync, ACE Pro, etc.) and attempts to match a filament preset before falling back to the existing material-type matching. - Add PresetCollection::filament_id_by_id_or_name() which tries matching by filament_id, setting_id, preset name (exact then case-insensitive/base-name) - Use it in MoonrakerPrinterAgent::fetch_moonraker_filament_data() for both filament_id and setting_id fields from lane_data - Add name-based fallback in PresetBundle::sync_ams_list() and get_ams_cobox_infos() for user presets that have no filament_id
broncosis
force-pushed
the
feat/filament-id-preset-editor
branch
from
June 29, 2026 01:33
137be55 to
e0320d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Recordings/Graphs
Tests
How to Download Pull Requests Artifacts for Testing