Add DKLS23 soft-spoken presignatures - #269
Open
toufic0710 wants to merge 4 commits into
Open
toufic0710 wants to merge 4 commits into
toufic0710 wants to merge 4 commits into
Conversation
Author
|
Open questions:
|
toufic0710
force-pushed
the
feature/dkls23-presignatures
branch
from
July 14, 2026 13:47
9e625b4 to
6bf6ffa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #255
Previously, all final signing logic lived in
pkg/mpc/signatures/ecdsa/dkls23/signing_softspoken/rounds.go, insideRound5: it computed the message-independent values, hashed the message, and returned a partial signature.This PR splits that logic across the following files:
pkg/mpc/signatures/ecdsa/dkls23/presignature.goDefines the shareddkls23.PreSignaturetype, its CBOR encoding/ decoding, andFinalise, which turns a presignature into a partial signature once the message is known.pkg/mpc/signatures/ecdsa/dkls23/signing_softspoken/ presignature.goContains the soft-spokenPreSignlogic extracted from the oldRound5. This is the message-independent part of round 5.pkg/mpc/signatures/ecdsa/dkls23/signing_softspoken/rounds.goKeeps the existingRound5API, now implemented asPreSignfollowed byFinalise.pkg/mpc/signatures/ecdsa/dkls23/presign_softspoken/runner.goAdds a high-level runner that executes the soft-spoken signing rounds up toPreSign, producing a presignature before the message is known.Tests cover both the round-level split and the presignature runner path.
We don't need additive key derivation or "raw signing", so we did not implemented rerandomization.
Pull Request Checklist
Scope
Testing (select all that apply)
Documentation / Spec (if relevant)
Notes