Skip to content

Stabilize launch-test timeouts to prevent CI false negatives#20

Draft
brow1633 with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-ci-ros-iron-job
Draft

Stabilize launch-test timeouts to prevent CI false negatives#20
brow1633 with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-ci-ros-iron-job

Conversation

Copilot AI commented Jun 20, 2026

Copy link
Copy Markdown

CI / ROS iron (main) (pull_request) failed due to a launch test timeout (test_test_zmq.py) that did not emit a result file before CTest’s timeout window. The failure mode indicates timing sensitivity in CI rather than a deterministic logic regression.

  • Root cause

    • Launch-test timeout configuration in CMakeLists.txt was too aggressive for slower CI runners.
    • Timeout-triggered termination caused missing xUnit output (test_test_zmq.py.xunit.missing_result).
  • Change made

    • Introduced a shared, configurable launch-test timeout in BUILD_TESTING scope:
      • NETWORK_BRIDGE_LAUNCH_TEST_TIMEOUT (default: 30)
    • Replaced hardcoded launch test timeouts for existing launch tests to use the shared value.
  • Why this shape

    • Keeps behavior centralized and tunable.
    • Applies consistently across launch tests without touching test logic.
set(NETWORK_BRIDGE_LAUNCH_TEST_TIMEOUT 30 CACHE STRING "Timeout in seconds for launch tests")

add_launch_test(
  test/test_udp.py
  TIMEOUT ${NETWORK_BRIDGE_LAUNCH_TEST_TIMEOUT}
)
add_launch_test(
  test/test_tcp.py
  TIMEOUT ${NETWORK_BRIDGE_LAUNCH_TEST_TIMEOUT}
)

Copilot AI changed the title [WIP] Fix failing GitHub Actions job for CI / ROS iron Stabilize launch-test timeouts to prevent CI false negatives Jun 20, 2026
Copilot AI requested a review from brow1633 June 20, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants