Made reference changes, and import changes in files, Added a parameter to check if the face is in the frame - #322
Open
Apoorv012 wants to merge 5 commits into
Open
Made reference changes, and import changes in files, Added a parameter to check if the face is in the frame#322Apoorv012 wants to merge 5 commits into
Apoorv012 wants to merge 5 commits into
Conversation
Contributor
|
Thank you, will review this soon. Might be nice to separate the whitespace changes from code changes, but not a big deal. |
Merged
l-ouis
suggested changes
Feb 3, 2025
l-ouis
left a comment
l-ouis
left a comment
Contributor
There was a problem hiding this comment.
The style changes are nice!
It'll probably be simpler to just let users call checkEyesInValidationBox() if they can't already instead of copying the value to another value each loop call.
| if( webgazer.params.showFaceFeedbackBox ) | ||
| checkEyesInValidationBox(); | ||
| if (webgazer.params.showFaceFeedbackBox) | ||
| params.faceInFrame = checkEyesInValidationBox(); |
Contributor
There was a problem hiding this comment.
I'm not sure if the parameters is the correct place for this -- it seems more like a flag than a preset parameter. Maybe we can just let the user call checkEyesInValidationBox() freely if they can't already?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.jsto.mjswebgazer.paramsto justparamsparams.faceInFrameto check if the face is inside the frame.