Skip to content

fix(render): re-encode audio across segment joins - #163

Open
a27851305-hue wants to merge 2 commits into
browser-use:mainfrom
a27851305-hue:fix-aac-concat-clicks
Open

a27851305-hue wants to merge 2 commits into
browser-use:mainfrom
a27851305-hue:fix-aac-concat-clicks

Conversation

@a27851305-hue

@a27851305-hue a27851305-hue commented Sep 15, 2026

Copy link
Copy Markdown

Summary

  • preserve stream-copy for the video track during segment concat
  • re-encode AAC audio once into a continuous 48 kHz, 192 kbps stream to avoid per-segment encoder priming/padding clicks
  • add a regression test for the generated ffmpeg command

This addresses the audio-click portion of #162. The larger automatic boundary-QC proposal remains separate.

Testing

  • python -m unittest discover -s tests -v (17 tests passed)

Summary by cubic

Re-encodes audio during segment concat to fix clicks from per-segment AAC encoder priming/padding, while preserving lossless video copy. Previously the concat used -c copy for every track; now audio is re-encoded into one continuous 48 kHz, 192 kbps AAC stream. Adds a regression test for the generated ffmpeg command.

Written for commit 6ad7a2f. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant