feat: Configurable IncluHeader configuration item#5
Open
salleh wants to merge 17 commits intobrpaz:masterfrom
Open
feat: Configurable IncluHeader configuration item#5salleh wants to merge 17 commits intobrpaz:masterfrom
salleh wants to merge 17 commits intobrpaz:masterfrom
Conversation
Since the forked repo appeared to be unmaintained, we are pulling this open PR in: brpaz#4 Signed-off-by: Valério Valério <vdv100@gmail.com>
Explicitly mention that this is a public fork
Signed-off-by: Valério Valério <vdv100@gmail.com>
Merge skipper middleware configuration from Unity-Technologies/echozap
salleh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce IncludeHeader as new ZapLoggerConfig item.
The IncludeHeader will default to nil. To include specific header into the log item, pass a string slice that contains the list of header key:
e.g:
echozap.ZapLoggerConfig{ IncludeHeader: []string{ echo.HeaderXRequestId, "My-Custom-Header-Key", } }For consistency purpose, ALL the header key will be converted to lowercase before registered as the log field key (as getting the header from the http context will assume a case insensitive canonical form).
POTENTIAL BREAKING CHANGES TO RUNTIME RESULT
Prior and including version 1.1.3 of #brpaz/echozap, echozap will automatically add a log field "request-id" to represent "X-Request-Id" header regardless if it is being sent or not.
With this release, it is not automatically added anymore. The log field key will not be changed and it will maintain the original header key.