Allow logger to be lazy and converted on first use#14
Open
Allow logger to be lazy and converted on first use#14
Conversation
mberlanda
previously approved these changes
Oct 14, 2019
Member
mberlanda
left a comment
There was a problem hiding this comment.
Overall I trust you 😄
Would it be possible to add a test and/or an example of configuration with and without proc? This would make the change more documented
Collaborator
Author
|
If you have a look at the labels there is a Usually, I change it when I've added tests and in some way or form verified that the code does what I expect it to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem otherwise is that there is a load order problem in unique jobs. At least this way I can assign the logger regardless of how files are loaded.