Skip to content

Improve tree view by adding indents and vertical lines and aligning texts - #85

Merged
brufdev merged 4 commits into
brufdev:devfrom
m42cel:dev
Aug 28, 2025
Merged

brufdev merged 4 commits into
brufdev:devfrom
m42cel:dev

Conversation

@m42cel

@m42cel m42cel commented Aug 24, 2025

Copy link
Copy Markdown
Contributor

Improve tree view by

  • indenting directory contents one level below the directory name,
  • aligning the text of directories and files within the same directory, and
  • adding vertical lines that span the contents of directories

Closes #80

m42cel added 2 commits August 24, 2025 13:43
* indenting directory contents one level below the directory name,
* aligning the text of directories and files within the same directory, and
* adding vertical lines that span the contents of directories

Closes #80
Also use `class="relative w-full"` on the root level.

@brufdev brufdev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

I believe the issues with the development environment are caused by the missing broadcasting service. Add the following to you .env file:

SCOUT_DRIVER=null
BROADCAST_CONNECTION=null

I would prefer you stick with TailwindCSS for everything, so instead of the class, you could add: pl-2 ml-2 border-l-2 border-light-base-300 dark:border-base-500. Please double-check if this produces the same result, as I haven't tested it. This adds the color to both themes as well.

Can you confirm these changes on a vault containing only files? Just to check, that the padding on the left doesn't seem too much without the chevrons.

I will work on other things first but I can finish this later if you can't.

@m42cel

m42cel commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for pointing out the tailwind classes, I totally agree! I guess then we'd also just add them to the element directly without a custom class in between?

I checked the colors again, and while your choice was pretty spot on with my first color I think border-light-base-400 works a little better.

And you had a good point with the indent with a files only vault. It indeed look a little too much:

grafik

We could counter it by also indenting the vault name

grafik

I also noticed that the vault title could use a font-semibold, which would make it stand out a little from its contents and would also look just as in the vault overview.

This would be with indent and semibold:

grafik

@brufdev

brufdev commented Aug 28, 2025

Copy link
Copy Markdown
Owner

About the indent, I was thinking of only indenting files if there are folders at that level, but maybe that could be confusing. I'll try it out and see how it looks.

Thank you!

@brufdev
brufdev merged commit 41ab5d6 into brufdev:dev Aug 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants