fix: preserve artifact tags in multipart uploads - #621
Draft
mfroembgen wants to merge 2 commits into
Draft
Conversation
mfroembgen
marked this pull request as ready for review
August 3, 2026 17:43
mfroembgen
marked this pull request as draft
August 3, 2026 17:44
mfroembgen
force-pushed
the
codex/620-multipart-artifact-tag
branch
2 times, most recently
from
August 10, 2026 05:52
237dd21 to
c9d2208
Compare
mfroembgen
force-pushed
the
codex/620-multipart-artifact-tag
branch
from
August 10, 2026 06:04
c9d2208 to
781aa49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The storage layer already passes
x-artifact-tagas S3 user metadata. rust-s3 0.37.2 applies those per-upload headers to single-partPutObject, but does not forward them toCreateMultipartUploadonce the first chunk reaches 8 MiB. S3 metadata must be supplied during multipart initiation.The linked rust-s3 change forwards streaming-builder headers to initiation using a request-scoped bucket clone. Existing public APIs, multipart parts/completion, bounded concurrency, error propagation, and credential-provider behavior remain unchanged.
Verification
cargo fmt --all -- --checkRUSTFLAGS=-Dwarnings cargo clippycargo test --all-features(11 unit tests and 18 end-to-end tests)cargo build --release --lockedReleased 4.0.13 behavior:
x-artifact-tagFinal scratch container against MinIO:
x-artifact-tagDependency coordination
This draft pins the full immutable commit from durch/rust-s3#471 so it can be tested end to end. It should move to a released rust-s3 version, or another maintainer-approved immutable upstream reference, before becoming ready to merge.
Fixes #620