Repository navigation
🛡️ Sentinel: [HIGH] Fix XSS Risk in Email Preview - #363
brycejohnson1417 wants to merge 1 commit into
Conversation
Replaced dangerouslySetInnerHTML with a sandboxed iframe using srcDoc to provide defense-in-depth against XSS vulnerabilities when rendering email previews. Added inline styles to preserve typography and restricted sandbox permissions to allow popups (links) but block scripts. Co-authored-by: brycejohnson1417 <257422776+brycejohnson1417@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch was successfully deployed
1 participant
🚨 Severity: HIGH
💡 Vulnerability: XSS risk from rendering untrusted HTML via
dangerouslySetInnerHTMLin the PPP Savings Panel. Even with DOMPurify, Defense in Depth dictates using sandboxed iframes.🎯 Impact: An attacker could potentially inject malicious scripts that execute in the context of our application if DOMPurify is bypassed or misconfigured.
🔧 Fix: Replaced
dangerouslySetInnerHTMLwith a sandboxed<iframe>utilizing thesrcDocattribute. Thesandboxattribute is set to"allow-popups allow-popups-to-escape-sandbox"to permit links while blocking scripts. Inline CSS is injected to preserve typography.✅ Verification: Verified locally by running linting, typechecking, and viewing the rendered iframe in the browser using Playwright. No scripts can execute within the iframe.
PR created automatically by Jules for task 17334945044136885259 started by @brycejohnson1417