Skip to content

🎨 Palette: [UX improvement] #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brycejohnson1417 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: [UX improvement] #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-24 - Role=Switch Buttons Need Aria Labels
**Learning:** Custom toggle switches (`<button role="switch">`) that are icon-only or lack embedded visible text must explicitly include an `aria-label` or `aria-labelledby` to ensure screen reader accessibility.
**Action:** Adding `aria-label={label}` to the `role="switch"` button in `PluginToggle` in `components/fraternitees/fraternitees-portal.tsx`.
2 changes: 2 additions & 0 deletions components/fraternitees/fraternitees-portal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ function PluginToggle({
<button
type="button"
role="switch"
aria-label={label}
aria-checked={enabled}
disabled={disabled}
onClick={onToggle}
Expand Down Expand Up @@ -1037,6 +1038,7 @@ export function FraterniteesWorkspace({
<button
type="button"
role="switch"
aria-label="Toggle Automatic daily sync"
aria-checked={dailyAutoSync.enabled}
onClick={() => void updateDailyAutoSync(!dailyAutoSync.enabled)}
className={classNames(
Expand Down
Loading