Repository navigation
π‘οΈ Sentinel: [CRITICAL/HIGH] Fix XSS vulnerability in email preview - #373
brycejohnson1417 wants to merge 1 commit into
Conversation
β¦erHTML with a sandboxed iframe Co-authored-by: brycejohnson1417 <257422776+brycejohnson1417@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
π¨ Severity: HIGH
π‘ Vulnerability: Used
dangerouslySetInnerHTMLto render email preview incomponents/accounts/ppp-savings-panel.tsx, which can expose the application to potential XSS attacks.π― Impact: An attacker could inject malicious scripts into the email preview, which would execute in the victim's browser context.
π§ Fix: Replaced
dangerouslySetInnerHTMLwith aniframeleveraging thesrcDocattribute and asandboxattribute (sandbox="allow-popups allow-popups-to-escape-sandbox"). Injected styles inline into thesrcDocHTML string to maintain the UI styling.β Verification: Ran
npm run lint,npm run typecheck, tenant-isolation checks, and visually verified the UI via Playwright script, ensuring theiframerenders properly and the UI isn't broken.PR created automatically by Jules for task 12989894392352407329 started by @brycejohnson1417