Repository navigation
🛡️ Sentinel: [HIGH] Fix XSS in email preview - #376
brycejohnson1417 wants to merge 1 commit into
Conversation
Replaced `dangerouslySetInnerHTML` with a sandboxed `iframe` using `srcDoc` and inline styling in `ppp-savings-panel.tsx`, restricting script execution and same-origin access. Co-authored-by: brycejohnson1417 <257422776+brycejohnson1417@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2abb01dee0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div className="min-h-[24rem] w-full overflow-auto bg-white p-6 text-sm text-black"> | ||
| <div dangerouslySetInnerHTML={{ __html: sanitizedEmailHtml }} /> | ||
| <div className="min-h-[24rem] w-full overflow-hidden bg-white text-sm text-black"> | ||
| <iframe |
There was a problem hiding this comment.
This changes browser-rendering and security behavior in the PPP email preview, making it a meaningful implementation slice, but the diff contains no docs/runs/ report recording the validation performed and remaining risk; .jules/sentinel.md does not follow the run-report template. Add the required report so the claimed Playwright and project-check results are auditable.
AGENTS.md reference: AGENTS.md:L39-L39
Useful? React with 👍 / 👎.
This branch was successfully deployed
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Used
dangerouslySetInnerHTMLfor rendering email HTML, creating potential XSS vectors.🎯 Impact: If sanitization failed, malicious scripts could be executed in the context of the user's session.
🔧 Fix: Replaced
dangerouslySetInnerHTMLwith a sandboxediframeusingsrcDocand inline styling, restricting script execution and same-origin access.✅ Verification: Verified visually via Playwright and ran standard project checks (
npm run lint,npm run typecheck, etc).PR created automatically by Jules for task 14156002965706306349 started by @brycejohnson1417