You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: keep form controls readable across device themes - #205
Dark device settings activated black form surfaces while the app retained its light palette and dark text. Keep the existing app consistently light, give shared and native controls explicit readable defaults, and make placeholder contrast consistent across legacy screen overrides. Autofill preserves dark entered text on a light surface.
Seven files form one shared form-contrast fix; no provider, data, authentication, schema, or layout behavior changes. Existing component and design-system patterns are preserved.
Validation: browser RED reproduced dark controls with roughly 1.1:1 text contrast. Final npm run verify passed lint, typecheck, 60 test files / 263 tests, Prisma validation, and production build. Five Chromium E2E tests passed: all visible Settings text inputs, password fields, textareas, and native selects meet 4.5:1 text/placeholder contrast on mobile/desktop with light/dark device preferences and a previously saved dark theme; Mailjet connect/cancel/test/disconnect controls remain functional using fixtures. Before/after screenshots and interaction video captured locally.
Remaining limits: no live provider sends from these tests, no exhaustive audit of every application workflow, and real password-manager autofill across browsers remains unverified. Production proof pending deployment.
Browser RED reproduced low contrast under dark device settings. Expanding the same form-contrast scope to components/mobile/settings-mobile.tsx: two textarea placeholder overrides still fall below 4.5:1 after the shared fix. No overlap with previously checked open PRs. These overrides will use the shared accessible placeholder color.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.
Released to https://piccnewyork.org at main c6c7dff. Production deployment is READY. Signed-in Settings verification confirms light theme, a white field surface with dark text, and working connection controls. Before/after screenshots and interaction recording were captured locally. Full application-wide visual coverage and real password-manager autofill across browsers are not claimed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatGPT Codex Connector
Closes #204.
Dark device settings activated black form surfaces while the app retained its light palette and dark text. Keep the existing app consistently light, give shared and native controls explicit readable defaults, and make placeholder contrast consistent across legacy screen overrides. Autofill preserves dark entered text on a light surface.
Seven files form one shared form-contrast fix; no provider, data, authentication, schema, or layout behavior changes. Existing component and design-system patterns are preserved.
Validation: browser RED reproduced dark controls with roughly 1.1:1 text contrast. Final npm run verify passed lint, typecheck, 60 test files / 263 tests, Prisma validation, and production build. Five Chromium E2E tests passed: all visible Settings text inputs, password fields, textareas, and native selects meet 4.5:1 text/placeholder contrast on mobile/desktop with light/dark device preferences and a previously saved dark theme; Mailjet connect/cancel/test/disconnect controls remain functional using fixtures. Before/after screenshots and interaction video captured locally.
Remaining limits: no live provider sends from these tests, no exhaustive audit of every application workflow, and real password-manager autofill across browsers remains unverified. Production proof pending deployment.