Fix Windows tray icon callbacks failing due to thread safety issues

[Copilot]

• Explore repository structure and understand the codebase
• Identify the root cause of Windows tray icon issues
• Fix Windows tray implementation to use thread-safe callbacks
• Refactor based on feedback: wrap callbacks at call site instead of passing tkinter_root
• Simplify macOS tray implementation by removing redundant thread marshalling
• Improve documentation based on code review
• Run final code review
• Run security scan

Original prompt

On windows closing the application and the tray icon isnt working well. clicking quit in the tray menu does nothing and i cant get the window back with show window

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[bryfur]

@copilot I dont like passing the tkinter root in, should the callbacks just all pass in wrapped in tkinter after, ensure all tray implementations would work correctly with that setup

[Copilot]

@copilot I dont like passing the tkinter root in, should the callbacks just all pass in wrapped in tkinter after, ensure all tray implementations would work correctly with that setup

Done! I've refactored the solution to wrap callbacks with root.after() at the call site instead of passing tkinter_root to the tray implementations. This keeps the tray implementations simpler and platform-agnostic.

The callbacks are now wrapped in MainWindow._setup_tray():

on_show=lambda: self.root.after(0, self._show_window),
on_quit=lambda: self.root.after(0, self.quit_app),
# etc.

This approach ensures thread safety while maintaining clean separation of concerns. Commit: 9eeba2e

[bryfur]

@copilot can we simplify the macos tray now that callbacks are always on the main loop