Skip to content

Fix unchecked checkbox primary display - #269

Merged
brylie merged 2 commits into
mainfrom
fix/issue-106-unchecked-checkbox-primary
Sep 12, 2026
Merged

Fix unchecked checkbox primary display#269
brylie merged 2 commits into
mainfrom
fix/issue-106-unchecked-checkbox-primary

Conversation

@brylie

@brylie brylie commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary:

  • Render unchecked checkbox primary fields as Unchecked.
  • Cover both checkbox display values in the shared view formatter test.
  • Align the collection-view specification with the display contract.

Verification:

  • npx vitest run src/lib/data/views.test.ts
  • npx vitest run src/lib/components/BoardCollectionView.svelte.test.ts src/lib/components/CalendarCollectionView.svelte.test.ts
  • npm run check
  • npm run test
  • npm run lint

Closes #106

Summary by CodeRabbit

  • New Features
    • Calendar entries now show the resolved primary field as an editable title alongside dates and other visible properties.
  • Bug Fixes
    • Board and Calendar views now consistently handle primary fields that duplicate grouping controls.
    • Non-editable titles are used when an editable primary-field cell is unavailable.
    • Checkbox fields now display “Unchecked” when not selected, instead of appearing blank.
  • Documentation
    • Updated collection views documentation to reflect primary-field title behavior.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: e7c98d78-8e3d-4746-ba41-46a459b1afea

📥 Commits

Reviewing files that changed from the base of the PR and between 83fe6a7 and 0c3685f.

📒 Files selected for processing (1)
  • docs/specifications/collection-views.md

Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.


📝 Walkthrough

Walkthrough

The checkbox primary-field display now returns "Unchecked" for false values. The related test verifies the behavior, and the collection-views specification documents it.

Changes

Checkbox display value correction

Layer / File(s) Summary
Update checkbox display contract and validation
src/lib/data/views.ts, src/lib/data/views.test.ts, docs/specifications/collection-views.md
primaryFieldDisplayValue returns "Unchecked" for false checkbox values. The test and specification reflect the updated behavior.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 0c368

The change cleanly distinguishes checked and unchecked checkbox values without altering primary-field selection or collection-view rendering contracts.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing the unchecked checkbox primary-field display.
Linked Issues check ✅ Passed Issue #106 requires a non-empty unchecked checkbox display value and a test. primaryFieldDisplayValue now returns "Unchecked" for checkbox value false and keeps "Checked" for true. `src/li…
Out of Scope Changes check ✅ Passed The reviewed changes are limited to the shared checkbox display formatter, its test coverage, and the collection-view specification. These changes directly support issue #106. No unrelated product beh…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-106-unchecked-checkbox-primary

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Render unchecked primary checkboxes as Unchecked

🐞 Bug fix 🧪 Tests 📝 Documentation 🕐 Less than 10 minutes

Grey Divider

AI Description

• Render false checkbox primary values as “Unchecked” instead of an empty title.
• Verify both checkbox states in the shared primary-field formatter test.
• Document the explicit checkbox display contract for collection views.
Diagram

graph TD
  C["Checkbox Value"] --> F["Display Formatter"] --> P["Plain Title"] --> V["Board / Calendar"]
  T["Formatter Tests"] -. verifies .-> F
  D["View Specification"] -. documents .-> F
Loading
High-Level Assessment

The current approach is optimal: fixing the shared primary-field formatter corrects every existing plain-text consumer consistently, while the focused test and specification update prevent contract drift. Consumer-specific fallbacks would duplicate behavior and risk inconsistent titles.

Files changed (3) +6 / -4

Bug fix (1) +1 / -1
views.tsRender false checkbox values as Unchecked +1/-1

Render false checkbox values as Unchecked

• Changes primaryFieldDisplayValue to return “Unchecked” for false checkbox primary fields, preventing blank Board and Calendar titles.

src/lib/data/views.ts

Tests (1) +4 / -2
views.test.tsCover both checkbox display states +4/-2

Cover both checkbox display states

• Updates the shared formatter test to expect “Unchecked” for false checkbox values while retaining coverage for “Checked” true values.

src/lib/data/views.test.ts

Documentation (1) +1 / -1
collection-views.mdDocument explicit unchecked checkbox titles +1/-1

Document explicit unchecked checkbox titles

• Updates the collection-view display contract to state that checkbox primary fields render as “Checked” or “Unchecked,” rather than leaving false values empty.

docs/specifications/collection-views.md

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

…ed-checkbox-primary

# Conflicts:
#	docs/specifications/collection-views.md
@brylie
brylie merged commit 2491e55 into main Sep 12, 2026
2 checks passed
@brylie
brylie deleted the fix/issue-106-unchecked-checkbox-primary branch September 12, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unchecked checkbox primary field displays as "Untitled" instead of a distinguishable value

1 participant