Skip to content

Add accessible labels to board and calendar inputs - #275

Closed
brylie wants to merge 0 commit into
mainfrom
codex/fix-board-calendar-input-labels
Closed

Add accessible labels to board and calendar inputs#275
brylie wants to merge 0 commit into
mainfrom
codex/fix-board-calendar-input-labels

Conversation

@brylie

@brylie brylie commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add accessible labels to property inputs and selects
  • Update board, calendar, and property cell tests to use accessible queries

Testing

  • Unit tests updated
  • Not run (not requested)

Summary by CodeRabbit

  • Accessibility

    • Added accessible labels to text, number, date, checkbox, and select property controls.
    • Improved screen reader and keyboard navigation support for property editing.
  • Tests

    • Updated component tests to locate editable fields by their accessible roles and labels, improving test coverage of accessible interactions.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: 0eb2f299-aeca-44cc-b47a-77b6e1fa3323

📥 Commits

Reviewing files that changed from the base of the PR and between 41b1d22 and 521e3a2.

📒 Files selected for processing (4)
  • src/lib/components/BoardCollectionView.svelte.test.ts
  • src/lib/components/CalendarCollectionView.svelte.test.ts
  • src/lib/components/PropertyValueCell.svelte
  • src/lib/components/PropertyValueCell.svelte.test.ts

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.


📝 Walkthrough

Walkthrough

Property controls now expose accessible labels for text, number, date, checkbox, and select inputs. Tests locate editable controls by role and accessible name.

Changes

Accessible property controls

Layer / File(s) Summary
Property control labels
src/lib/components/PropertyValueCell.svelte
Text, number, date, checkbox, and select controls now use each property label as their accessible name.
Accessible name test queries
src/lib/components/PropertyValueCell.svelte.test.ts, src/lib/components/BoardCollectionView.svelte.test.ts, src/lib/components/CalendarCollectionView.svelte.test.ts
Tests locate text and title controls by textbox role and accessible name.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 521e3

The accessibility labels and corresponding test queries are aligned; no merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding accessible labels to board and calendar property inputs and selects.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-board-calendar-input-labels

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Add accessible names to collection property controls

✨ Enhancement 🧪 Tests 🕐 10-20 Minutes

Grey Divider

AI Description

• Label property editors with their property names for assistive technologies.
• Query board, calendar, and cell inputs by accessible role and name.
Diagram

graph TD
  P["Property Definition"] --> C["Property Cell"] --> F["Form Controls"] --> A["Accessibility Tree"] --> T["Cell Tests"]
  A --> V["View Tests"]
Loading
High-Level Assessment

Using each property definition's existing label as the control's accessible name is the most direct approach for compact collection cells. Explicit or visually hidden label elements were considered, but would add repeated markup and layout complexity without improving the accessible naming outcome here.

Files changed (4) +10 / -3

Enhancement (1) +5 / -0
PropertyValueCell.svelteAdd accessible names to property editor controls +5/-0

Add accessible names to property editor controls

• Applies the property label as an accessible name for text, number, date, checkbox, and select controls. Assistive technologies can now identify editors by their corresponding property names.

src/lib/components/PropertyValueCell.svelte

Tests (3) +5 / -3
BoardCollectionView.svelte.test.tsQuery the board title editor by accessible name +2/-1

Query the board title editor by accessible name

• Finds the title textbox through its role and 'Title' accessible name, then separately verifies its initial value before editing.

src/lib/components/BoardCollectionView.svelte.test.ts

CalendarCollectionView.svelte.test.tsQuery the calendar title editor by accessible name +2/-1

Query the calendar title editor by accessible name

• Locates the calendar title textbox by role and accessible name, while retaining an explicit assertion for its initial value.

src/lib/components/CalendarCollectionView.svelte.test.ts

PropertyValueCell.svelte.test.tsVerify property inputs through accessible queries +1/-1

Verify property inputs through accessible queries

• Updates the text property test to locate its textbox by both semantic role and the 'Name' accessible label.

src/lib/components/PropertyValueCell.svelte.test.ts

@brylie brylie closed this Sep 12, 2026
@brylie
brylie force-pushed the codex/fix-board-calendar-input-labels branch from 521e3a2 to 5169233 Compare September 12, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant