Conversation
Author
|
I have ansible automation that sets upbgbackup and bgrestore. My restore dumps the backup into preppath to be restored. This way less space is needed but incremental backups are not supported in that mode. |
bgrestore's prepit()/restoreit() duplicated fgrestore's decrypt/decompress/ prepare/move-back logic with an older, non-chain-aware implementation. bgrestore now only does what's genuinely its own (backup_history lookup, logging, the MDEV-6660 workaround, starting the service) and hands the actual restore to fgrestore, which is chain-aware (Full/Differential/ Incremental) and checks exit status at every step. Also adds -c|--config CLI parsing and a service_name config variable (replacing a hardcoded "mariadb" service) with a matching per-service lock file, so restore tests can run against multi-instance hosts.
fgrestore is chain-aware now, so there's no reason to wait for the next Full when the latest successful backup is a Differential or Incremental -- fgrestore trickles back to the Full on its own. Drops the butype = 'Full' filter from the backup_history lookup and renames lastfullinfo()/ lastfulluuid/lastfullbulocation accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we try out bgbackup and bgrestore, you put everything on the same box. The bgrestgore configuration is much different, with this change they are the same.