Skip to content

refactor(topo): address linter violations and style in topo nodes (4/5) - #15

Open
bstoll wants to merge 1 commit into
mainfrom
cleanup-4-5-topo-nodes
Open

refactor(topo): address linter violations and style in topo nodes (4/5)#15
bstoll wants to merge 1 commit into
mainfrom
cleanup-4-5-topo-nodes

Conversation

@bstoll

@bstoll bstoll commented Jul 9, 2026

Copy link
Copy Markdown
Owner

This is part 4/5 of an overall cleanup effort to fix golangci-lint violations and format files across the repository. In this step:

  • Replace k8s.io/utils/pointer with k8s.io/utils/ptr in node implementations.
  • Standardize error formatting and simplify struct field accesses.
  • Rename internal fields for clarity (wantInitCtr -> wantInitContainer, wantSonicCtr -> wantSonicContainer in sonic.go).
  • Fix spelling mistakes in log messages and strings.

@coveralls

coveralls commented Jul 9, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29054969415

Coverage decreased (-0.02%) to 42.035%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: 35 uncovered changes across 9 files (46 of 81 lines covered, 56.79%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
topo/node/node.go 17 2 11.76%
topo/topo.go 13 8 61.54%
topo/node/forward/forward.go 4 0 0.0%
topo/node/drivenets/drivenets.go 3 0 0.0%
topo/node/openconfig/openconfig.go 5 2 40.0%
topo/node/cisco/cisco.go 17 15 88.24%
topo/node/alpine/alpine.go 6 5 83.33%
topo/node/arista/arista.go 4 3 75.0%
topo/node/nokia/nokia.go 2 1 50.0%
Total (11 files) 81 46 56.79%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
topo/topo.go 1 80.45%

Coverage Stats

Coverage Status
Relevant Lines: 12342
Covered Lines: 5188
Line Coverage: 42.04%
Coverage Strength: 0.48 hits per line

💛 - Coveralls

@bstoll
bstoll force-pushed the cleanup-4-5-topo-nodes branch 3 times, most recently from 380100b to bc2f547 Compare July 9, 2026 18:36
This is part 4/5 of an overall cleanup effort to fix linter issues and format files across the repository.
In this step:
- Address linter issues and style formatting across topology node implementations (alpine, arista, cisco, drivenets, forward, juniper, nokia, openconfig, sonic).
- Refactor error handling and test formatting in topo module.
@bstoll
bstoll force-pushed the cleanup-4-5-topo-nodes branch from bc2f547 to 20c8110 Compare July 9, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants