Skip to content

test - #17

Closed
bstoll wants to merge 14 commits into
mainfrom
hines-fork
Closed

test#17
bstoll wants to merge 14 commits into
mainfrom
hines-fork

Conversation

@bstoll

@bstoll bstoll commented Jul 22, 2026

Copy link
Copy Markdown
Owner

No description provided.

anh-nguyen-ciena and others added 13 commits June 25, 2026 22:14
* Modified proto/topo/topo.proto
  * add Ciena vendor and ciena_saos type
* Modified proto/topo/topo.pb.go
  * changes generated by topo.proto
* Modified topo/topo.go
  * add ciena node into import
* Added topo/node/ciena/ciena.go
  * ciena node implementation
* Added proto/ciena.proto
  * add Ciena proto - define Ciena specific vendor data for KNE
* Added proto/ciena/ciena.pb.go
  * file generated by proto/ciena.proto
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 6.4.0 to 6.5.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@4a36011...924ae3a)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-version: 6.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.3 to 7.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@df4cb1c...9c091bb)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.10.0 to 4.2.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@b5ca514...bb05f3f)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-version: 4.2.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add cloudbuild config to release meshnet

This builds a docker image and pushes it to artifact registry

* Fix lint warning

* check err return of cloudbuild Close()
* prettier format YAML
* Don't spellcheck go.sum

* Update build so it executes in Github Actions env

* Remove unwanted references to master branch

* Separate interactive element from help function

Review comment - remove side effect IO from helper function,
return a descriptive error then handle it in the main function.

I preserved the prompt behavior because this code is based on
openconfig/lemming/cmd/release/release.go, so I thought it best to maintain
consistent behavior to that existing code.

* Add the release command under 'internal'

Make the release command a subcommand within 'internal'. This follows
the pattern established in lemming and avoids a separate main.
This is cleanup that resolves some Google-internal linter warnings.
There should be no change in behavior.
* Have KNE reference its internal fork of meshnet

* Remove default dependence on networkop/meshnet-cni

Use the images we now publish from internal code instead

* Update package version after release

* Use third_party/meshnet/v0.3.3 as the tag format

This is to match Go's expectation on package version

* The tag convention is ga rather than latest

* Fix lint errors
@coveralls

coveralls commented Jul 22, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29897695645

Coverage increased (+0.08%) to 42.141%

Details

  • Coverage increased (+0.08%) from the base build.
  • Patch coverage: 275 uncovered changes across 8 files (216 of 491 lines covered, 43.99%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
cmd/release/release.go 140 12 8.57%
proto/ciena/ciena.pb.go 110 0 0.0%
topo/node/ciena/ciena.go 227 203 89.43%
cmd/internal/internal.go 8 0 0.0%
topo/node/node.go 2 0 0.0%
cmd/root.go 1 0 0.0%
controller/server/main.go 1 0 0.0%
deploy/deploy.go 1 0 0.0%
Total (9 files) 491 216 43.99%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
cmd/root.go 1 4.94%

Coverage Stats

Coverage Status
Relevant Lines: 12819
Covered Lines: 5402
Line Coverage: 42.14%
Coverage Strength: 0.48 hits per line

💛 - Coveralls

@bstoll bstoll closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants