Persist detached settings window geometry - #397
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ceiling | dc4bb9a | Commit Preview URL Branch Preview URL |
Aug 23 2026, 06:53 PM |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_0ef577ed-1fa1-4c35-a5f0-d7b3a5a92b9c) |
|
Warning Review limit reached
Next review available in: 15 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # CHANGELOG.md
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6f116e6e-f5c9-4010-bb82-c79e0e9962cd) |
# Conflicts: # CHANGELOG.md
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_978aa559-27c2-4a74-a72d-3565180dbfcd) |
Fixes #275.
Restores and clamps the saved detached Settings size and position, persists user move and resize events, and removes the mount-time frontend override. Adds focused native and frontend regression tests.
Note
Low Risk
Window placement only. No auth, credentials, or data-handling changes. First open with no stored geometry still uses the default size and centered position.
Overview
The detached Settings window now reopens at its last size and position instead of being recentered and resized on every open.
Native open now loads stored geometry, applies it at create time, and clamps the position on-screen. Move and resize events persist through
handle_window_event. The frontend no longer callssetSize/setPositionon mount, which had been overwriting the restored layout.Reviewed by Cursor Bugbot for commit dc4bb9a. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Persist detached Settings window geometry across sessions
geometry_storeon move/resize viashell::settings_window::handle_window_event, skipping minimized/maximized states.open_or_focusloads stored geometry forSurfaceMode::Settingswhen creating the window, falling back to defaults, and usesposition::default_surface_positionfor initial placement.applySettingsWindowSizeutil and its mountuseEffectfrom Settings.tsx, so the frontend no longer overwrites backend-restored geometry on open.setSize/setPositionare not called.shell::settings_window::handle_window_eventbefore main-window-only logic in thetauri Builderon_window_eventclosure in main.rs; if that handler returns early, main-window handlers are skipped.Macroscope summarized dc4bb9a.