Skip to content

Detect the Antigravity CLI by image name when CommandLine is empty - #445

Merged
btsouth merged 1 commit into
mainfrom
fix/antigravity-agy-detection
Sep 15, 2026
Merged

btsouth merged 1 commit into
mainfrom
fix/antigravity-agy-detection

Conversation

@btsouth

@btsouth btsouth commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Hardens Antigravity process detection for the standalone CLI (#412).

The detector's PowerShell filter already selects agy.exe by image name, but the parser then re-derived the match from the command line. If WMI returns an empty CommandLine for a running agy.exe, the emitted line was just the PID, nothing matched, and Ceiling reported "Antigravity language server not running" even though the CLI was up and its local quota API answered.

The query now emits <pid>\t<image name>\t<command line>, and a matched agy.exe / antigravity-cli image name is accepted even when the command line is empty. Two-column output still parses, so the existing paths are unchanged.

I could not reproduce the reporter's exact failure on a Windows 11 VM: with a stand-in agy.exe, detection matched and advanced to port discovery, and even an elevated agy.exe exposed its CommandLine to a non-elevated query. This change covers the empty-CommandLine case, which is the most likely cause, without regressing the matched paths.

Testing: cargo test (rust lib, 1237 tests), cargo clippy --all-targets -D warnings, cargo fmt --check. Added tests for the three-column line, the empty command line, and a non-Antigravity image name.

Note

Detect Antigravity CLI by image name when CommandLine is empty

Updates AntigravityProvider process detection to capture the image name alongside PID and command line from PowerShell/WMI output. Adds is_cli_image_name to classify processes like agy.exe or names containing antigravity-cli even when the command line is empty. The parse_process_info parser now handles the new three-column format while remaining compatible with the legacy two-column format.

  • CLI classification combines command-line and image-name detection; IDE classification and connection-argument extraction still rely on the command-line field
  • Adds regression and negative tests covering three-column parsing, empty command-line detection, and rejection of unrelated image names like chrome.exe

Macroscope summarized beeea63.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ceiling beeea63 Commit Preview URL

Branch Preview URL
Sep 15 2026, 11:30 PM

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a15f48af-ed34-470f-8208-63216c032795

📥 Commits

Reviewing files that changed from the base of the PR and between 3937fab and beeea63.

📒 Files selected for processing (1)
  • rust/src/providers/antigravity/mod.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@btsouth
btsouth merged commit f45a379 into main Sep 15, 2026
10 checks passed
@btsouth
btsouth deleted the fix/antigravity-agy-detection branch September 15, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant