Update rustls and h2 past their advisories - #449
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ceiling | 1941bb8 | Commit Preview URL Branch Preview URL |
Sep 18 2026, 12:33 AM |
Two advisories in
Cargo.lock, both with a patched version available.rustls 0.23.39 to 0.23.45 (RUSTSEC-2026-0285, CVSS 5.3)
Rustls accepted TLS 1.3 handshake messages at the wrong encryption level when they followed a key-changing message in the same record, so a peer could send handshake messages that should have been encrypted in plaintext without the connection being rejected. Patched in
>= 0.23.45.Reachable in the shipped build.
cargo tree --target x86_64-pc-windows-msvc -i rustls:Same shape on
aarch64-pc-windows-msvc.h2 0.4.13 to 0.4.19 (RUSTSEC-2026-0258)
Unbounded empty DATA frames, patched in
>= 0.4.16. Reached throughhyper 1.9.0, whichreqwest,hyper-util,hyper-rustlsandmockitopull in. Worth being precise about this one: unlike rustls it is not in the Windows dependency graph (cargo tree --target <windows> | grep h2is empty), it rides in the lockfile through hyper's optional h2 dependency. It is one command to keep clean and it becomes reachable the day that feature is enabled.Change
Cargo.lockonly. Three package versions move, no manifest change:rustls0.23.39 to 0.23.45rustls-webpki0.103.13 to 0.103.15 (follows rustls)h20.4.13 to 0.4.19Commands run
I did not finish a cross-target
cargo checklocally (the whole filesystem is out of btrfs unallocated space and the build tripped ENOSPC), so compile and test coverage for this lands on theRust / sharedandRust / desktopjobs in CI.Follow-up worth considering
This repo's CI has no Rust advisory step at all, which is why both of these sat invisible while
mainstayed green. Acargo auditstep in theRust / sharedjob would have caught them. There are currently 11 advisories that would report as warnings rather than failures (fxhash,proc-macro-error, theunic-*set,event-listener,glib,rand 0.7), so a gate would need a decision about which of those to waive. Say the word and I will open it as a separate change.Note
Update
rustlsandh2past security advisories inCargo.lockBumps
rustlsandh2to versions beyond their advisory thresholds. Only the lockfile is touched.Macroscope summarized 1941bb8.