fix(activity): distinguish load failures from empty results in three Activity panels (#728)

[Vermitrude]

Fixes #728. DiscoveryTraces, ToolIdentities, and LiveInspector now track loading/ready/error status the same way the audit log and security-event panels already do, instead of collapsing a rejected fetch into an empty-state message. ToolIdentities no longer returns null on a failed load. Tests cover a rejected fetch for each panel.

Note

Distinguish load failures from empty results in three Activity panels

• Adds reusable PanelLoadingNotice and PanelErrorNotice components to ActivityView.tsx
• Updates DiscoveryTraces, ToolIdentities, and LiveInspector to track loading, ready, and error states with a retry counter
• Load failures now render a retryable alert instead of the empty state, and initial loads show a loading notice
• Behavioral Change: DiscoveryTraces, ToolIdentities, and LiveInspector effect dependency arrays now include a retry counter to support refetches on retry clicks

^{Macroscope summarized 736ec7a.}

[btsouth]

This is the right shape. The three panels now separate a failed load from an empty one and the retry paths are covered by tests. Thanks for sticking with it through the environment trouble.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 12e4b9ff-66ce-4a50-8f6a-b3ab719a248f

📥 Commits

Reviewing files that changed from the base of the PR and between d702073 and 736ec7a.

📒 Files selected for processing (2)

• src/components/ActivityView.test.tsx
• src/components/ActivityView.tsx

---

📝 Walkthrough

Walkthrough

ActivityView now shows loading and retryable error states for discovery, tool identities, and live inspection. Tests cover rejected requests, retry actions, and successful empty results.

Changes

Activity panel load-state handling

Layer / File(s)	Summary
Discovery load state src/components/ActivityView.tsx, src/components/ActivityView.test.tsx	Discovery now tracks request status, shows loading and error notices, supports retry, and distinguishes failed loads from empty results.
Tool identities load state src/components/ActivityView.tsx, src/components/ActivityView.test.tsx	Tool identities now preserves existing rows during refresh failures, shows a retryable error, and avoids treating failures as missing data.
Live inspector load state src/components/ActivityView.tsx, src/components/ActivityView.test.tsx	Live inspection now distinguishes loading, failed loading, and an empty capture buffer. The tests configure controllable API spies and verify retry behavior.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: btsouth

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}