Cocoa: Fix opening dialogs from another thread#148
Open
jay3d wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the PR! This has been raised before in #46, and I kind of think that it is the responsibility of the user to call the file dialog on the main thread. Both macOS and Linux/GTK require the dialog to be called from the main thread, and it is generally recommended to keep all UI work on the main thread. It also requires that the main thread is not blocked by anything else, so it might cause surprising behaviour for downstream consumers if that isn't the case. If Java's threading system is really an issue for many people, maybe we could have a flag to explicitly opt into this just for the purpose of building a Java library, but otherwise I do not think we should encourage this use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix will prevent crashes with
NSWindowwhen trying to open dialogs from another thread.