Check copy success and report in CSV report for failures. - #42
Open
milechin wants to merge 1 commit into
Open
Conversation
Add a check of the copy command exit code. If the exit code is not zero, then it is assumed the copy of the test directory had failed and so the test fails. This failure is now recorded in the CSV report. This was not reported before.
Collaborator
|
Thank you for the good fix and the good writing of what has been fixed. One question I couldn't help to bring up is that - is this 'permission denied' behavior when copying test/ folder over happened to the previous month batch tests as well, or it is new? in either case, we may ask further why it wasn't detected or why it only happened in this month's run? |
Collaborator
|
I tested this code with this: But all tasks failed: Example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check of the copy command exit code. If the exit code is not zero, then it is assumed the copy of the test directory had failed and so the test fails. This failure is now recorded in the CSV report. This was not reported before.
Context
Looking at the November nextflow job log file
pkgautotest_cronjob.o1168887, it indicates 7 tests failed for the following modules:Majority of the failures was because of "permission denied" errors when copying the "test" directory. Since this failure was at the Nextflow level, this failure was not recorded in the CSV output.
The updated Nextflow script now checks the exit code for the copy command. If the exit code is not 0, then the test is marked as "failed" in the CSV report.