Skip to content

Conversation

@igoromote
Copy link

No description provided.

@igoromote igoromote force-pushed the feat/notifications branch from f85dbda to b739398 Compare March 5, 2024 14:57
app.use('/task-updates', routersFactory.createTaskUpdatesRouter()) // Mount the boards router

// AMQP Listener setup
void setupAMQP()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provavelmente não é a melhor arquitetura.+

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

há necessidade de ter criado outro módulo do ampq mesmo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Então, eu acho que dá para usar o mesmo, mas como esse módulo precisa estar ativo "sempre", enquanto o outro ele só inicia dado determinado cenário, tive que criar aqui na "main", mas podemos refatorar fazendo com que esse módulo seja utilizado pelos outros

Copy link
Contributor

@rodrigoantas rodrigoantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igoromote igoromote requested a review from rodrigoantas March 7, 2024 19:12
@igoromote igoromote force-pushed the feat/notifications branch from 244b60c to f973858 Compare March 13, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants