Make the fetcher update transitive maven deps in buf.plugin.yml#2342
Open
Make the fetcher update transitive maven deps in buf.plugin.yml#2342
Conversation
So that we don't error out on duplicate maven deps. When a dependency plugin's Maven version is updated (e.g. protocolbuffers/java moves from v33.5 to v34.0), consumers that have stale pins (e.g. grpc/java still pinning protobuf-java:4.33.5 from the previous copy) would hit version conflicts during deduplication. Now RegenerateMavenDeps walks the transitive dep tree, collects Maven artifact versions, and updates the plugin's buf.plugin.yaml before deduplication. This ensures all downstream consumers have consistent versions and dedup succeeds.
stefanvanburen
approved these changes
Mar 18, 2026
pkwarren
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we don't error out on duplicate maven deps