Fix map entry field features and generate missing feature locations#684
Merged
Fix map entry field features and generate missing feature locations#684
Conversation
doriable
commented
Mar 18, 2026
mcy
reviewed
Mar 18, 2026
experimental/ir/lower_features.go
Outdated
|
|
||
| // featureOptionsForMapEntryField is a helper function for setting valid feature options | ||
| // from the map field to the given map entry field. | ||
| func featureOptionsForMapEntryField(file *File, r *report.Report, mapEntryField, mapField Member) { |
Member
There was a problem hiding this comment.
This doesn't feel right to me. I would have thought you wanted to set up the parent of the FeatureSet of the map entry type to be the FeatureSet of the map field. Then everything should happen automatically, I think.
Member
Author
There was a problem hiding this comment.
Discussed in person -- we're going to push this logic to fdp generation.
mcy
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some more conformance issues:
also inherit these options