Pretty-print SourceCodeInfo in IR test goldens#686
Merged
Conversation
doriable
approved these changes
Mar 18, 2026
Member
doriable
left a comment
doriable
left a comment
There was a problem hiding this comment.
This looks good to me, there might be some merge issues ^^" But stamping this first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current test goldens for
SourceCodeInfoare unreadable. This PR adds a stand-alone SCI decoder specifically for use in goldens, and adds support toprototest/yaml.gofor printing arbitrary Go values.The
SourceCodeInfogolden is broken out into its own test output, separate from the FDP.This PR also adds a helper binary that decodes an FDS's
SourceCodeInfo, for easily extracting what protoc is doing.