Add method to ir.Value to check if it is from a top-level option declaration#687
Merged
Add method to ir.Value to check if it is from a top-level option declaration#687
ir.Value to check if it is from a top-level option declaration#687Conversation
mcy
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a method to
ir.Valueto check whether itis from a top-level option declaration for source.
This allows us to fix an issue in the file descriptor generator,
where we need to determine whether a message option value
corresponds with a top-level option declaration in source.
This also adds a
DescriptorOptionto generate additional locationsfor the elements within the option message literals, similar to the old
SourceInfoMode = SourceInfoExtraOptionLocations.