Fix parser handling of message field values and group-in-oneof legalization#688
Merged
Fix parser handling of message field values and group-in-oneof legalization#688
Conversation
…zation Parse message field values with parseExprPrefix instead of parseExprInfix so that infix keywords like "to" are not consumed as part of the value. Allow groups inside oneof definitions, and remove the IsLeaf guard that prevented colon-less fields with angle-bracket message expressions.
mcy
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix infix expression parsing for colon-less field values in message literals
by checking for valid tokens ahead. Also, no longer require a leaf check for
message literals.
Also, allow groups inside oneof definitions.