Conversation
bufdev
left a comment
There was a problem hiding this comment.
Non-strict should definitely not be the default. This makes protoyamls behavior different than protojson, and overall surprising.
pkwarren
left a comment
There was a problem hiding this comment.
Change looks good but agree this shouldn't be the default.
Do you plan to also add a plugin option in the JSON schema plugin to include shorter enum names?
|
Every change also requires a change to the json schema plugin. |
|
Honestly, because there are no backwards compatibility issues, there should be no option. This change only changes what used to be an error in to an intuitive non-error case. If any option should be supported it is the option to specify which one you want the jsonschema plugin to suggest, which is external to this library. |
Co-authored-by: Philip K. Warren <pkwarren@users.noreply.github.com>
Co-authored-by: Philip K. Warren <pkwarren@users.noreply.github.com>
When StrictEnums is false, the following is now allowed:
The following is always allowed:
Note that this does not impact 'encoding', which always produces protojson-compatible output.