Support more YAML edge cases including aliases and merge#64
Open
garuma wants to merge 1 commit intobufbuild:mainfrom
Open
Support more YAML edge cases including aliases and merge#64garuma wants to merge 1 commit intobufbuild:mainfrom
garuma wants to merge 1 commit intobufbuild:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use YAML as a configuration format that we then transform to protobuf.
In those cases, people tend to leverage the more advanced features of YAML (including aliases and merges) which I have combined support for in this PR (let me know if you want it split).
I added unit tests for each new cases.