fix: escape key in hint popup not counted as action; arcade mode headers#200
Merged
fix: escape key in hint popup not counted as action; arcade mode headers#200
Conversation
github-actions
bot
added
bug
fix: arcade sub-modes now display correct header title (#197) - In handle_task_keys, guard Escape key when hint panel is visible: return Message::ShowHint (toggle/dismiss) instead of falling through to ExecuteCommand("Escape"), which was incorrectly counted as a player action and granted mastery credit to the Escape key. - Add mode_title() helper in minigame renderer that matches on MiniGameMode to return the correct header string. Survival and Daily Challenge now show their own titles instead of "ARCADE MODE".
bug-ops
force-pushed
the
fix/194-escape-hint-counted-as-actio
branch
from
ef02281 to
40033f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecuteCommand("Escape"), incorrectly counting as a player action and degrading scores. Added a guard inhandle_task_keysthat detects Escape while the hint panel is open and returnsMessage::ShowHint(toggle/dismiss) instead.ARCADE MODEheader. Addedmode_title()helper in the minigame renderer that matches onMiniGameModeand returns the correct title for each mode.Test plan
?to open hint, pressEscapeto close — score remains unaffected, no "Mastery Up: Escape" notificationSURVIVAL MODEDAILY CHALLENGECloses #194
Closes #197