fix: lower Excellent rating threshold from 90% to 80%#202
Merged
Conversation
The Excellent tier (previously 90-99%) was mathematically unreachable with all existing scenarios where optimal_count <= 7. With optimal=7 and actual=8 the score is 87%, which skipped directly from Perfect to Good. Lower Excellent to 80-99%, Good to 60-79%, Fair to 40-59%, Poor to <40%. With the new thresholds, optimal=4/actual=5 (80%) and optimal=7/actual=8 (87%) both correctly yield Excellent. Add regression tests verifying Excellent is reachable with realistic scenario data.
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Excellentperformance tier threshold from 90% to 80% so it is reachable with all existing scenariosoptimal_count <= 7Root cause
The Excellent tier (90-99%) was mathematically unreachable: with
optimal_count <= 7(current max in all scenario files), the first suboptimal score isfloor(7/8 * 100) = 87%, which fell into Good, skipping Excellent entirely. The tier existed in code but was never shown to users.Fix
Lower Excellent threshold to 80%. With this change:
optimal=4, actual=5→ 80% = Excellentoptimal=7, actual=8→ 87% = ExcellentTest plan
cargo nextest run— all 1857 tests passcargo clippy --all-targets --all-features -- -D warnings— no warningscargo +nightly fmt --check— no formatting issuesCloses #201