fix(core): use effective_model() fallback in /provider switch#2156
Merged
fix(core): use effective_model() fallback in /provider switch#2156
Conversation
When entry.model is None, the runtime model name was set to the provider type string (e.g. "ollama", "claude") instead of the actual default model. Add ProviderEntry::effective_model() to zeph-config that returns the explicit model or the per-type default, and use it in provider_cmd.rs.
github-actions
bot
added
rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entry.modelisNone,/provider <name>was setting the runtime model name to the provider type string (e.g."ollama","claude") instead of the actual default modelProviderEntry::effective_model()inzeph-configreturning the explicit model or per-type defaults matching those inbuild_provider_from_entryprovider_cmd.rswith a singleentry.effective_model()callTest plan
zeph-configcover all provider-type defaults and explicit model overridecargo nextest run --workspace --lib --bins— 5994 tests, 0 failures/provider statusnow shows the correct model name after switching to a provider with no explicitmodelfield