fix(config): add [security.guardrail] stub to default.toml for migrate-config#2161
Merged
fix(config): add [security.guardrail] stub to default.toml for migrate-config#2161
Conversation
…h-skills Add crates/zeph-skills/skills -> ../../.zeph/skills symlink so build.rs and bundled.rs reference $CARGO_MANIFEST_DIR/skills instead of the brittle ../../.zeph/skills traversal.
…e-config Configs with [security] but no [security.guardrail] section were not getting the guardrail commented defaults injected by --migrate-config. The migration logic derives its reference from default.toml; the stub was simply absent, so nothing could be injected. Adds [security.guardrail] with all default field values and comments. No migration code changes required. Fixes #2158.
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--migrate-configwas not injecting commented[security.guardrail]defaults for configs that have[security]but no[security.guardrail]sectionconfig/default.tomlhad no[security.guardrail]entry; the migration logic can only inject what exists in the reference[security.guardrail]with all default field values and comments toconfig/default.toml; no migration code changes requiredFixes #2158.
Test plan
cargo nextest run --config-file .github/nextest.toml --workspace --lib --bins— all 6003 tests pass includingmigrate::tests::security_without_guardrail_gets_guardrail_commentedcargo +nightly fmt --check— cleancargo clippy --workspace -- -D warnings— clean