Skip to content

fix(socket): handle partial writes for large WebSocket payloads #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roxblnfk merged 2 commits into from
Apr 7, 2026
+17 −2
Merged

fix(socket): handle partial writes for large WebSocket payloads #213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03c0773
Initial plan
Copilot Apr 7, 2026
56b03bc
fix(socket): handle partial socket_write() for large WebSocket payloads
Copilot Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/Socket/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,23 @@ protected function processPayload(string $payload): void
private function writeQueue(): void
{
foreach ($this->writeQueue as $data) {
\socket_write($this->socket, $data);
// Logger::debug('Respond %d bytes', $x);
$length = \strlen($data);
$written = 0;
while ($written < $length) {
$result = \socket_write($this->socket, \substr($data, $written));
if ($result === false) {
$errno = \socket_last_error($this->socket);
// If the send buffer is temporarily full, suspend the fiber and retry
if ($errno === \SOCKET_EAGAIN || $errno === \SOCKET_EWOULDBLOCK) {
\socket_clear_error($this->socket);
\Fiber::suspend();
continue;
}
// Unrecoverable error, stop writing
break 2;
}
$written += $result;
}
}
\socket_set_nonblock($this->socket);

Expand Down
Loading