Bug 2052126: BugmailFilter extension: smart handling of components.id type#158
Closed
justdave wants to merge 3 commits into
Closed
Bug 2052126: BugmailFilter extension: smart handling of components.id type#158justdave wants to merge 3 commits into
justdave wants to merge 3 commits into
Conversation
justdave
changed the title
mrenvoize
previously approved these changes
Jul 3, 2026
mrenvoize
left a comment
mrenvoize
left a comment
Contributor
There was a problem hiding this comment.
All looks good to me and works
justdave
force-pushed
the
bug-2052126-harmony
branch
from
3c6fd12 to
2f9e952
Compare
Member
Author
|
I rearranged the order of dependencies because of testing necessity. This now depends on #162 to land first before this does. |
Member
Author
|
Closing this. Merged it into #162 because it's all related anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This extension breaks in Harmony when upgrading from a 5.0 or 5.2 install. This PR makes it be smart about handling the size of the components.id column during installation and upgrading (this is mirroring behavior already in use by the ComponentWatching extension).
This depends on PR #157 because it uses the helper function introduced in that PR and #162 because it depends on the component.id size change. For review purposes looking only at the Bug 2052126 commit instead of the entire PR will work best, until #157 and #162 land and main gets merged here again.
Additional info
Test Plan
docker compose updocker compose downdocker compose upand watch the output to confirm that checksetup.pl no longer shows the foreign key error and makes it past where that was previously happening.