Skip to content

[FEAT]: Add team command group#727

Open
mcncl wants to merge 2 commits intomainfrom
SUP-6704/team_commands
Open

[FEAT]: Add team command group#727
mcncl wants to merge 2 commits intomainfrom
SUP-6704/team_commands

Conversation

@mcncl
Copy link
Copy Markdown
Contributor

@mcncl mcncl commented Mar 29, 2026

Description

Adds support for group of team commands, as available in go-buildkite

Changes

  • adds team {create,delete,list,update,view}
  • adds tests for the new commands
  • updates main.go to support
❯ go run . team create Testers
{
  "id": "89cea5f7-a7c0-4183-b48c",
  "name": "Testers",
  "slug": "testers",
  "privacy": "visible",
  "default": false,
  "created_at": "2026-03-29T23:20:04.042Z",
  "created_by": {
    "id": "01831b25-7d66-431e-8dcf",
    "name": "Ben McNicholl",
    "email": "ben.mcnicholl@buildkite.com",
    "created_at": "2022-09-08T03:29:45.318Z"
  }
}

❯ go run . team list
[
  {
    "id": "3c911fd5-cf8f-4a45-814d",
    "name": "Everybody",
    "slug": "everybody",
    "description": "The default team",
    "privacy": "visible",
    "default": true,
    "created_at": "2026-03-16T02:08:21.763Z",
    "created_by": {
      "id": "01831b25-7d66-431e-8dcf",
      "name": "Ben McNicholl",
      "email": "ben.mcnicholl@buildkite.com",
      "created_at": "2022-09-08T03:29:45.318Z"
    }
  },
  {
    "id": "89cea5f7-a7c0-4183-b48c",
    "name": "Testers",
    "slug": "testers",
    "privacy": "visible",
    "default": false,
    "created_at": "2026-03-29T23:20:04.042Z",
    "created_by": {
      "id": "01831b25-7d66-431e-8dcf",
      "name": "Ben McNicholl",
      "email": "ben.mcnicholl@buildkite.com",
      "created_at": "2022-09-08T03:29:45.318Z"
    }
  }
]

❯ go run . team delete 89cea5f7-a7c0-4183-b48c --yes
Team deleted successfully.

Testing

  • Tests have run locally (with go test ./...)
  • Code is formatted (with go fmt ./...)

@mcncl mcncl requested review from a team as code owners March 29, 2026 23:22
cmd/team/list.go Outdated
var err error

spinErr := bkIO.SpinWhile(f, "Loading teams information", func() {
teams, _, err = f.RestAPIClient.Teams.List(ctx, f.Config.OrganizationSlug(), nil)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any concerns about not paginating here? I'm not sure how many teams we return per page, but I'm guessing sooner or later we will come across someone who has hundreds of them.

Description: current.Description,
Privacy: current.Privacy,
IsDefaultTeam: current.Default,
MembersCanCreatePipelines: false,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude flagged the fact that every time someone updates a team, it's going to set members_can_create_pipelines: false even if the current setting for that team is true. "Balderdash," said I. "Prove it!" So we looked at go_buildkite, where it turns out that the Team struct doesn't include all the fields that the API returns, including MembersCanCreatePipelines. And then looking upstream at the API in Team::Updater and how it would handle this, it looks like it would in fact apply the false flag and change the setting unexpectedly. We'd need to fix this in go_buildkite and then here do MembersCanCreatePipelines: current.MembersCanCreatePipelines,

If this makes sense to you, I can throw the PR at go_buildkite and then add a commit to this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think false is a sensible default? It's definitely safer than true and would still allow for creation of the team but with safeguards in place.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in Slack - we still need to fix go_buildkite to avoid us forcibly changing this setting when we update teams. That'll be a separate task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants