Open
Conversation
| ) | ||
|
|
||
| // CleanupCmd deletes remote bk/preflight/* branches whose builds have completed. | ||
| type CleanupCmd struct { |
Contributor
There was a problem hiding this comment.
I think we should allow providing a specific preflight UUID to target.
Contributor
Author
There was a problem hiding this comment.
@matthewborden would you want cleanup without args to clean up all branches, then if we supply --preflight-uuidwe only target that one? Or would you want UUID to be accepted as an optional positional arg, or allow the user to set --all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables the user to run a
cleanupsubcommand to delete branches which are left stale after a build has run to completion. Allows for--dry-runto be used.Changes
cleanupcommand which will delete any branches with the patternbk/preflight/*PreflightCmd->RunCmd)Testing
go test ./...)go fmt ./...)