Refactor security policies and disable block editor notes - #26
Merged
Conversation
Strip editor.notes post-type support late on init and at registration so the post editor does not request /wp/v2/comments?type=note after wp-baseline unregisters the comments REST routes.
Add UserRegistrationPolicy and wire into Security init for WaaS tenants.
This class contained a hard dependency on Polaris\API, which has no place in a standalone baseline package. Moved to Polaris\ManagedSite where it belongs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the way comment-related features are disabled, especially focusing on block editor notes and REST API requests, and improves the login error handling logic. The most important changes are grouped below:
Comment and Editor Notes Disabling Improvements:
/wp/v2/comments?type=noteREST API requests when comments are disabled. This addresses issues with the collaboration sidebar and ensures no REST conflicts. (inc/Comments/Actions.php,README.md) [1] [2] [3] [4]inc/Comments/Actions.php)Login Error Handling Improvements:
inc/Security/Login.php)inc/Security/Login.php)